Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update adblock-rust to v0.3.4 #7412

Merged
merged 1 commit into from
Dec 22, 2020
Merged

Update adblock-rust to v0.3.4 #7412

merged 1 commit into from
Dec 22, 2020

Conversation

antonok-edm
Copy link
Collaborator

@antonok-edm antonok-edm commented Dec 11, 2020

Resolves brave/brave-browser#13101

Blocked on brave/adblock-rust-ffi#27

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Visit https://www.imdb.com/video/vi886815769?playlistId=tt1568346&ref_=vp_rv_ap_0 and verify that the video plays when clicked. It should not enter an infinite redirect loop.

@antonok-edm antonok-edm added the dependencies Pull requests that update a dependency file label Dec 11, 2020
@antonok-edm antonok-edm self-assigned this Dec 11, 2020
@antonok-edm antonok-edm marked this pull request as ready for review December 12, 2020 23:40
@antonok-edm antonok-edm requested review from bridiver, bsclifton and bbondy and removed request for bridiver and bsclifton December 12, 2020 23:40
@antonok-edm antonok-edm force-pushed the adblock-rust-0.3.4 branch 6 times, most recently from ecd3e94 to af9e39b Compare December 18, 2020 18:02
@antonok-edm
Copy link
Collaborator Author

iOS test failure is known and unrelated. Otherwise, should be ready for merge - could I get a review? @bridiver @bbondy @bsclifton

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@antonok-edm antonok-edm merged commit 7c87647 into master Dec 22, 2020
@antonok-edm antonok-edm deleted the adblock-rust-0.3.4 branch December 22, 2020 15:55
@mihaiplesa mihaiplesa mentioned this pull request Dec 26, 2020
23 tasks
mkarolin pushed a commit that referenced this pull request Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to view video on imdb.com
3 participants